Handle config decoding errors from DB charset issues#333
Merged
Conversation
jrauh01
force-pushed
the
docs/database-encoding
branch
2 times, most recently
from
7dbe4bd to
832c8fb
Compare
nilmerg
requested changes
May 5, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
Instead of documenting this, Alex's suggestion makes more sense. (To use the correct encoding automatically) Icinga\Module\Notifications\Common\Database can do that.
jrauh01
force-pushed
the
docs/database-encoding
branch
from
832c8fb to
cf0f817
Compare
jrauh01
force-pushed
the
docs/database-encoding
branch
from
cf0f817 to
7f68bc3
Compare
nilmerg
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the database's character set is not set correctly, the decoding of the config attributes may fail. For that case an error message will be rendered in the form. There will also be a docs entry to prevent that.
Closes #271